[CI] Add ci workflows #6
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # TODO_NB - An important note to reference later | ||
| # TODO_DISCUSS_IN_THIS_COMMIT - SHOULD NEVER BE COMMITTED TO MASTER. It is a way for the reviewer of a PR to start / reply to a discussion. | ||
| # TODO_IN_THIS_COMMIT - SHOULD NEVER BE COMMITTED TO MASTER. It is a way to start the review process while non-critical changes are still in progress |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
# TODO_IN_THIS_COMMIT - SHOULD NEVER BE COMMITTED TO MASTER. It is a way to start the review process while non-critical changes are still in progress
| .PHONY: todo_this_commit | ||
| todo_this_commit: ## List all the TODOs needed to be done in this commit | ||
| grep -n --exclude-dir={.git,vendor,.vscode,.idea} --exclude={Makefile,reviewdog.yml} -r -e "TODO_IN_THIS_" |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
grep -n --exclude-dir={.git,vendor,.vscode,.idea} --exclude={Makefile,reviewdog.yml} -r -e "TODO_IN_THIS_"�
.github/workflows/run-tests.yml
Outdated
| with: | ||
| go-version: "1.22.2" | ||
|
|
||
| - name: Run golangci-lint |
There was a problem hiding this comment.
We need to install and configure it first. I don't remember exactly why, but we don't use the official github action on our main repo. We can try it in this repo! :)
If you don't want to look into this now — I'm happy to pick it up! In that case please remove make go_lint step.
There was a problem hiding this comment.
@okdas , I'd love to have a linter in this repo. Not sure how to proceed though.
There was a problem hiding this comment.
@red-0ne you can comment out this step, and I'll set up the golangci-lint next week then, would that work?
CI Update
This pull request includes the following updates to the CI workflow:
Issue and PR templates
Added the same issue and PR templates as in
poktroll.Workflows
Added reviewdog CI workflow including
TODO_IN_THIS_checks.Makefile targets
Added basic
Makefiletargets:make test_allmake go_lintTODOrelated targets